feat(sustainabot): migrate bot-integration from ReScript to AffineScr…#199
Merged
Conversation
…ipt (#148) Hand-port of bots/sustainabot/bot-integration/ from ReScript to AffineScript under explicit policy override of issue #148 (which previously forbade hand-porting ahead of the upstream mechanical migrator). Scope: - 11 .res files re-expressed as .affine (Types, Config, Webhook, Analysis, GitHubAPI, GitHubApp, Report, Router, Oikos, Main, tea/ServerTea). - Deleted .res/.res.js sources, lib/ocaml/ duplicates, bindings/, the vendored rescript-runtime/ Belt snapshot, and rescript.json. - Updated package.json + deno.json to target the AffineScript toolchain. - Added MIGRATION-NOTES.md documenting placeholders pending #161 (Json), #162 (Dict/Map), and Phase-3 of the migration assistant (#57/#314). Also unblocks PR #198: the governance "Language / package anti-pattern policy" check failed there because the .hypatia-ignore file the PR added isn't read by the upstream reusable workflow in hyperpolymath/standards. Removing the .res sources removes the root cause that the rule was firing on, so re-running the check on a main rebased over this commit should pass.
🔍 Hypatia Security ScanFindings: 135 issues detected
View findings[
{
"reason": "Issue in quality.yml",
"type": "missing_workflow",
"file": "quality.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in security-policy.yml",
"type": "missing_workflow",
"file": "security-policy.yml",
"action": "create",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
"type": "unpinned_action",
"file": "governance.yml",
"action": "pin_sha",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "expect() in hot path (1 occurrences, CWE-754)",
"type": "expect_in_hot_path",
"file": "/home/runner/work/gitbot-fleet/gitbot-fleet/bots/gsbot/src/services.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "expect() in hot path (3 occurrences, CWE-754)",
"type": "expect_in_hot_path",
"file": "/home/runner/work/gitbot-fleet/gitbot-fleet/bots/glambot/src/analyzers/accessibility.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "expect() in hot path (3 occurrences, CWE-754)",
"type": "expect_in_hot_path",
"file": "/home/runner/work/gitbot-fleet/gitbot-fleet/bots/finishingbot/src/analyzers/claims.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "expect() in hot path (1 occurrences, CWE-754)",
"type": "expect_in_hot_path",
"file": "/home/runner/work/gitbot-fleet/gitbot-fleet/bots/finishingbot/src/analyzers/license.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "expect() in hot path (1 occurrences, CWE-754)",
"type": "expect_in_hot_path",
"file": "/home/runner/work/gitbot-fleet/gitbot-fleet/bots/accessibilitybot/src/analyzers/aria.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "expect() in hot path (5 occurrences, CWE-754)",
"type": "expect_in_hot_path",
"file": "/home/runner/work/gitbot-fleet/gitbot-fleet/bots/accessibilitybot/src/analyzers/forms.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "expect() in hot path (4 occurrences, CWE-754)",
"type": "expect_in_hot_path",
"file": "/home/runner/work/gitbot-fleet/gitbot-fleet/bots/accessibilitybot/src/analyzers/media.rs",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ipt (#148)
Hand-port of bots/sustainabot/bot-integration/ from ReScript to AffineScript under explicit policy override of issue #148 (which previously forbade hand-porting ahead of the upstream mechanical migrator).
Scope:
Also unblocks PR #198: the governance "Language / package anti-pattern policy" check failed there because the .hypatia-ignore file the PR added isn't read by the upstream reusable workflow in hyperpolymath/standards. Removing the .res sources removes the root cause that the rule was firing on, so re-running the check on a main rebased over this commit should pass.